Skip to content

refactor(fdo): use openbao for key storage#1905

Closed
noaccOS wants to merge 44 commits intomasterfrom
bao
Closed

refactor(fdo): use openbao for key storage#1905
noaccOS wants to merge 44 commits intomasterfrom
bao

Conversation

@noaccOS
Copy link
Copy Markdown
Collaborator

@noaccOS noaccOS commented Apr 3, 2026

What this PR does / why we need it:

Currently we're storing plaintext private keys on db for FDO, which is a big no no
The chosen solution is openbao!

Additional documentation e.g. usage docs, diagrams, reviewer notes, etc.:

Thanks for sending a pull request! If this is your first time, here are some tips for you:
  1. You can take a look at our developer guide for an introduction on Astarte development!
  2. Make sure to read CONTRIBUTING.md and CODE_OF_CONDUCT.md
  3. If the PR is unfinished or you're actively working on it, mark it as draft

When fixing existing issues, use github's syntax to link your pull request to it

fixes #<issue number>

We also have a syntax to signal dependencies to other open pull requests

depends on #<pr number>
depends on https://github.com/...

In case of stacked PRs, you may add the PR number in the last commit's title instead:

gitGraph
    commit id: "Current master"
    branch feat1
    checkout feat1
    commit id: "feat: add something"
    commit id: "feat: add something else (#100)"
    branch feat2
    checkout feat2
    commit id: "refactor: do something"
    commit id: "fix: solve issue"
    commit id: "feat: add a feature (#101)"
    branch feat3
    checkout feat3
    commit id: "feat: feat without pr number"
Loading

noaccOS and others added 30 commits April 1, 2026 11:44
@noaccOS
refactor: adapt database structure for openbao
1f5f425 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@AliouneGaye21
refactor(fdo): begin refactor to2
26318d9
@frossq
refactor: make key algorithm explicit in load voucher (#1886)
411d44c 
Signed-off-by: frossq <francesco.asquini@secomind.com>
@AliouneGaye21
refactor(fdo): replacement voucher and key name (#1887)
17a61a4
@noaccOS
refactor: move create request to fdo_core
2c4a387 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@noaccOS
test: adjust ownership voucher tests
d30a44b 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@noaccOS
test: make tests run
e7d98e3 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@mizzet1
increase openbao tests codecov coverage (#1884)
c512f74 
Signed-off-by: Riccardo Nalgi <riccardo.nalgi@secomind.com>
@AliouneGaye21
test(fdo_core): make test run (#1888)
6795711
@noaccOS
test(fdo): restore working tests
41ee83f 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@AliouneGaye21
refactor(fdo): refactor create voucher on data_access (#1889)
ca6c150
@noaccOS
build(fdo_core): fix credo
453d493 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@noaccOS
test(fdo): fix load request tests
ed58d2d 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@noaccOS
chore(fdo): remove unused functions
ae9d8f9 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@mizzet1
feat(pairing): add get keys for algorithm api call (#1890)
2d35925 
Signed-off-by: Riccardo Nalgi <riccardo.nalgi@secomind.com>
@noaccOS
chore(secrets): fix ci
e1c9e8e 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@frossq
chore(fdo): enable TO2.Done tests to work with the new FDO implementa…
109b1c1 
…tion (#1891)

Signed-off-by: frossq <francesco.asquini@secomind.com>
@frossq
refactor: new KEX validation! (#1892)
c41e571 
Signed-off-by: frossq <francesco.asquini@secomind.com>
@AliouneGaye21
test(data_access): fix tests (#1893)
ec9dd19
@noaccOS
refactor(data_access): fix dialyzer
ed6afbc 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@noaccOS
chore: fix function calls
1de267e 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@noaccOS
test(fdo): fix load_request tests
dfe2122 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@noaccOS
test(fdo): fix owner_onboarding tests
dd9b4e9 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@frossq
chore: make ProveDevice tests working again (#1894)
8194391 
Signed-off-by: frossq <francesco.asquini@secomind.com>
@AliouneGaye21
test(fdo): fix session test (#1895)
627fd63 
Added Astarte.Secrets.decrypt/3 for asymmetric decryption.
@frossq
chore: make ProveDevice/ServiceInfo tests work again (#1898)
2073836 
Signed-off-by: frossq <francesco.asquini@secomind.com>
@noaccOS
fix(secrets): fix ecdh signature encoding
312b224 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@AliouneGaye21
test(fdo): fix fdo onboarding controller (#1899)
638b016
@mizzet1 @noaccOS
fix(pairing): re add key algorithm type logic (#1897)
c5bc49c 
Signed-off-by: Riccardo Nalgi <riccardo.nalgi@secomind.com>
Co-authored-by: Francesco Noacco <francesco.noacco@secomind.com>
@frossq @noaccOS
chore: fix flakiness in OwnerOnboardingTest (#1900)
0e8cd02 
* chore: fix flakiness in OwnerOnboardingTest

Signed-off-by: frossq <francesco.asquini@secomind.com>

* test(fdo): restore async

Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>

---------

Signed-off-by: frossq <francesco.asquini@secomind.com>
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
Co-authored-by: Francesco Noacco <francesco.noacco@secomind.com>
noaccOS and others added 5 commits April 3, 2026 10:42
@noaccOS
test(fdo): fix owner_onboarding_test setup_all
ca6ce51 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@AliouneGaye21
test(fdo): fix owner onboarding test (#1902)
de84f85
@noaccOS
test(fdo): merge owner onboarding tests
092fc7d 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@mizzet1 @noaccOS
fix(housekeeping): fix ownership_voucher migration table mismatch
5367b27 
Signed-off-by: Riccardo Nalgi <riccardo.nalgi@secomind.com>
@noaccOS
test(secrets): fix flakiness
d619fbc 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 73.65269% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.80%. Comparing base (7234b63) to head (d82e276).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
.../astarte_fdo/lib/ownership_voucher/load_request.ex 82.66% 13 Missing ⚠️
...rte_secrets/lib/astarte_secrets/astarte_secrets.ex 0.00% 13 Missing ⚠️
...data_access/lib/astarte_data_access/fdo/queries.ex 62.50% 6 Missing ⚠️
libs/astarte_fdo/lib/owner_onboarding.ex 64.70% 6 Missing ⚠️
libs/astarte_secrets/lib/astarte_secrets/core.ex 84.37% 5 Missing ⚠️
...e_fdo_core/lib/rendezvous/owner_sign/owner_sign.ex 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1905      +/-   ##
==========================================
+ Coverage   83.82%   84.80%   +0.98%     
==========================================
  Files         572      394     -178     
  Lines       10040     8339    -1701     
==========================================
- Hits         8416     7072    -1344     
+ Misses       1624     1267     -357
Files with missing lines Coverage Δ
...keeping/lib/astarte_housekeeping/realms/queries.ex 90.84% <ø> (ø)
...s/lib/astarte_data_access/fdo/ownership_voucher.ex 100.00% <100.00%> (ø)
..._access/lib/astarte_data_access/fdo/to2_session.ex 100.00% <ø> (ø)
..._fdo/lib/owner_onboarding/key_exchange_strategy.ex 100.00% <100.00%> (ø)
libs/astarte_fdo/lib/owner_onboarding/session.ex 84.74% <100.00%> (+1.10%) ⬆️
...ibs/astarte_fdo_core/lib/ownership_voucher/core.ex 29.41% <ø> (ø)
...e_fdo_core/lib/ownership_voucher/create_request.ex 92.85% <ø> (ø)
...ts/lib/astarte_secrets/owner_key_initialization.ex 100.00% <100.00%> (+100.00%) ⬆️
...e_fdo_core/lib/rendezvous/owner_sign/owner_sign.ex 0.00% <0.00%> (ø)
libs/astarte_secrets/lib/astarte_secrets/core.ex 92.00% <84.37%> (+24.12%) ⬆️
... and 4 more

... and 181 files with indirect coverage changes

Flag Coverage Δ
astarte_data_access 84.19% <64.70%> (-1.52%) ⬇️
astarte_events 80.27% <ø> (ø)
astarte_fdo 81.73% <81.18%> (+6.40%) ⬆️
astarte_fdo_core 61.38% <0.00%> (+0.75%) ⬆️
astarte_generators 97.74% <ø> (ø)
astarte_housekeeping_api ?
astarte_pairing ?
astarte_pairing_api ?
astarte_realm_management_api ?
astarte_rpc 88.23% <ø> (ø)
astarte_secrets 85.16% <62.50%> (+14.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mizzet1
fix(pairing): fix ownership_voucher_controller errors (#1904)
2c49d2a 
Signed-off-by: Riccardo Nalgi <riccardo.nalgi@secomind.com>
@noaccOS noaccOS mentioned this pull request Apr 3, 2026
Open
noaccOS and others added 8 commits April 3, 2026 16:09
@noaccOS
fix(pairing): ensure TO2 messages have correct content type (#1907)
977a6f2 
phoenix sometimes adds charset=utf8 to the content-type, which is not
compatible with our clients. manually set it to "application/cbor"
to avoid issues altogether

Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@noaccOS
ci: use stable astarte-device-fdo-rust in e2e (#1908)
5bd1abb 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@noaccOS
chore: forward port release-1.3
f11b412 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@noaccOS
chore: forward port master
a80ceb2 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@AliouneGaye21
refactor(fdo): re-enable credential reuse logic
5b1e9f0 
Signed-off-by: Alioune Gaye <alioune.gaye@secomind.com>
@noaccOS
refactor: remove assertive ov entry fetch
a812efc 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@noaccOS
refactor: move replacement data fetching logic to data_access
5defbe2 
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@mizzet1
fix(pairing): fix ownership_voucher_controller errors (#1913)
d82e276 
Signed-off-by: Riccardo Nalgi <riccardo.nalgi@secomind.com>
@noaccOS noaccOS marked this pull request as ready for review April 7, 2026 16:07
@noaccOS noaccOS closed this Apr 7, 2026
@noaccOS noaccOS deleted the bao branch April 7, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mizzet1 mizzet1 mizzet1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/xl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@noaccOS @mizzet1 @AliouneGaye21 @frossq